Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow charms to remove node labels via config #224

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Allow charms to remove node labels via config #224

wants to merge 5 commits into from

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Dec 19, 2024

Overview

Allows for charm config to influence the removal of node labels

Details

Incorporate changes here to remove unwanted node labels:

@addyess addyess requested a review from a team as a code owner December 19, 2024 18:16
addyess
addyess commented Dec 19, 2024
View reviewed changes
charms/worker/k8s/requirements.txt
charm-lib-node-base @ git+https://github.com/charmed-kubernetes/layer-kubernetes-node-base@a14d685237302711113ac651920476437b3b9785#subdirectory=ops
charm-lib-node-base @ git+https://github.com/charmed-kubernetes/layer-kubernetes-node-base@KU-2391/charm-ownership-of-node-role-labels#subdirectory=ops
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE WITH THIS OVERRIDE

@addyess addyess marked this pull request as draft December 19, 2024 18:16
@addyess
Copy link
Contributor Author

addyess commented Dec 19, 2024

Draft PR until charmed-kubernetes/layer-kubernetes-node-base#13 is merged

@github-actions GitHub Actions
Copy link
Contributor

Test coverage for ca5bdd6

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     278     29    90%
src/charm.py                              500    260    48%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   29      2    93%
src/containerd.py                         140     22    84%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                68     24    65%
src/inspector.py                           41      4    90%
src/kube_control.py                        43     32    26%
src/literals.py                            23      0   100%
src/protocols.py                           28      5    82%
src/reschedule.py                          77      4    95%
src/snap.py                               193     29    85%
src/token_distributor.py                  181    109    40%
src/upgrade.py                            108     48    56%
-----------------------------------------------------------
TOTAL                                    1822    583    68%
coverage-report: OK (1.22=setup[1.00]+cmd[0.21] seconds)
congratulations :) (1.27 seconds)

Static code analysis report

Run started:2024-12-20 03:50:43.669579

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3876
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@addyess